----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18093/#review34713 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp <https://reviews.apache.org/r/18093/#comment64928> This is clever, but falls in the 'just because you can, doesn't mean you should' category. You can get the same result by replacing the factory constructors above with: openOpen, openClosed, closedOpen, closedClosed. This is more explicit, less verbose, and less surprising. 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp <https://reviews.apache.org/r/18093/#comment64929> const T& return? 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp <https://reviews.apache.org/r/18093/#comment64932> could this be replaced by a method that gets both bounds in a pair? ie: std::pair<Bound<T>, Bound<T>> bounds() const; 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp <https://reviews.apache.org/r/18093/#comment64930> you can avoid the 'else' here as the 'if' is returning. 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp <https://reviews.apache.org/r/18093/#comment64934> could you use composition instead of inheritance here? It might avoid some of the awkward static_cast<...>(*this) constructions. It also means that users of the class won't be tempted to try to use the underlying interval_set directly. - Dominic Hamon On Feb. 16, 2014, 5:46 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18093/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2014, 5:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-993 > https://issues.apache.org/jira/browse/MESOS-993 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 51b118c > 3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18093/diff/ > > > Testing > ------- > > make check > > repeat 1000 times for the IntervalTest > > Repeating all tests (iteration 100) . . . > > Note: Google Test filter = *Interval* > [==========] Running 7 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 7 tests from IntervalTest > [ RUN ] IntervalTest.Interval > [ OK ] IntervalTest.Interval (0 ms) > [ RUN ] IntervalTest.Addition > [ OK ] IntervalTest.Addition (0 ms) > [ RUN ] IntervalTest.Subtraction > [ OK ] IntervalTest.Subtraction (0 ms) > [ RUN ] IntervalTest.Intersection > [ OK ] IntervalTest.Intersection (0 ms) > [ RUN ] IntervalTest.LargeInterval > [ OK ] IntervalTest.LargeInterval (0 ms) > [ RUN ] IntervalTest.ElementIteration > [ OK ] IntervalTest.ElementIteration (0 ms) > [ RUN ] IntervalTest.IntervalIteration > [ OK ] IntervalTest.IntervalIteration (0 ms) > [----------] 7 tests from IntervalTest (0 ms total) > > [----------] Global test environment tear-down > [==========] 7 tests from 1 test case ran. (0 ms total) > [ PASSED ] 7 tests. > > > Thanks, > > Jie Yu > >
