> On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 107 > > <https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line107> > > > > IMHO, providing element iteration can be sneaky and cause unintended > > performance issues. For example, consider a using IntervalSet for a very > > large interval which turns iteration (or the construction of a vector from > > such iteration) into an extremely expensive loop or a huge memory > > footprint. If we can get away without element iteration that would be > > preferred (but passing IntervalSet everyplace we used to use vector) or at > > least providing "interval" iteration instead of "element" (but let's not do > > this unless we really have a need.
Killed. > On Feb. 21, 2014, 12:12 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp, line 136 > > <https://reviews.apache.org/r/18093/diff/5/?file=499572#file499572line136> > > > > Did you consider about making these member operators? It seems that > > then we could do: > > > > template <typename X> > > IntervalSet<T>& operator += (const X& x) > > { > > operator += (static_cast<boost::icl::interval_set<T>&>(*this), x)); > > return *this; > > } > > > > Thoughts? I liked the idea! But your code does not compile because the compiler will try to match += (recursively) in IntervalSet. I changed a little bit, and it works: template <typename X> IntervalSet<T>& operator += (const X& x) { static_cast<boost::icl::interval_set<T>&>(*this) += x; return *this; } - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18093/#review35111 ----------------------------------------------------------- On Feb. 20, 2014, 11:46 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18093/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 11:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-993 > https://issues.apache.org/jira/browse/MESOS-993 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760 > 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18093/diff/ > > > Testing > ------- > > make check > > repeat 1000 times for the IntervalTest > > Repeating all tests (iteration 100) . . . > > Note: Google Test filter = *Interval* > [==========] Running 7 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 7 tests from IntervalTest > [ RUN ] IntervalTest.Interval > [ OK ] IntervalTest.Interval (0 ms) > [ RUN ] IntervalTest.Addition > [ OK ] IntervalTest.Addition (0 ms) > [ RUN ] IntervalTest.Subtraction > [ OK ] IntervalTest.Subtraction (0 ms) > [ RUN ] IntervalTest.Intersection > [ OK ] IntervalTest.Intersection (0 ms) > [ RUN ] IntervalTest.LargeInterval > [ OK ] IntervalTest.LargeInterval (0 ms) > [ RUN ] IntervalTest.ElementIteration > [ OK ] IntervalTest.ElementIteration (0 ms) > [ RUN ] IntervalTest.IntervalIteration > [ OK ] IntervalTest.IntervalIteration (0 ms) > [----------] 7 tests from IntervalTest (0 ms total) > > [----------] Global test environment tear-down > [==========] 7 tests from 1 test case ran. (0 ms total) > [ PASSED ] 7 tests. > > > Thanks, > > Jie Yu > >
