-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18093/#review35114
-----------------------------------------------------------
Ship it!
This is a great first step to commit, now that you only have the functionality
you'll be using. But, would it be beneficial to add TODOs for things we may
need? ('Interval' iteration seems pretty essential for those looking to process
the full set of values).
3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp
<https://reviews.apache.org/r/18093/#comment65522>
Is this useful outside of testing..?
3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp
<https://reviews.apache.org/r/18093/#comment65521>
#include <gtest/gtest.h>?
- Ben Mahler
On Feb. 20, 2014, 11:46 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18093/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2014, 11:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-993
> https://issues.apache.org/jira/browse/MESOS-993
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a760
> 3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18093/diff/
>
>
> Testing
> -------
>
> make check
>
> repeat 1000 times for the IntervalTest
>
> Repeating all tests (iteration 100) . . .
>
> Note: Google Test filter = *Interval*
> [==========] Running 7 tests from 1 test case.
> [----------] Global test environment set-up.
> [----------] 7 tests from IntervalTest
> [ RUN ] IntervalTest.Interval
> [ OK ] IntervalTest.Interval (0 ms)
> [ RUN ] IntervalTest.Addition
> [ OK ] IntervalTest.Addition (0 ms)
> [ RUN ] IntervalTest.Subtraction
> [ OK ] IntervalTest.Subtraction (0 ms)
> [ RUN ] IntervalTest.Intersection
> [ OK ] IntervalTest.Intersection (0 ms)
> [ RUN ] IntervalTest.LargeInterval
> [ OK ] IntervalTest.LargeInterval (0 ms)
> [ RUN ] IntervalTest.ElementIteration
> [ OK ] IntervalTest.ElementIteration (0 ms)
> [ RUN ] IntervalTest.IntervalIteration
> [ OK ] IntervalTest.IntervalIteration (0 ms)
> [----------] 7 tests from IntervalTest (0 ms total)
>
> [----------] Global test environment tear-down
> [==========] 7 tests from 1 test case ran. (0 ms total)
> [ PASSED ] 7 tests.
>
>
> Thanks,
>
> Jie Yu
>
>
