----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/#review35118 -----------------------------------------------------------
3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65527> not for this review, but it might be good to support the use case of adding a callback that depends on the previous Future not failing. Of course, then you could build a tree of callbacks depending on the state of the previous Futures, which may be useful in the far future. 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65529> this could be named 'addNothing' and the next be 'addCallback' to both not require the __ and be more descriptive. 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65530> this can move into the initializer section Sequence::Sequence() : process(new SequenceProcess()) { process::spawn(process); } 3rdparty/libprocess/include/process/sequence.hpp <https://reviews.apache.org/r/17476/#comment65531> Can you use an owned pointer for the process to save the explicit delete call in the destructor? - Dominic Hamon On Feb. 20, 2014, 4:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17476/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 4:56 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > One think I haven't done yet is to make it accepts '_Defer' types. (Just > curious why Future.onAny can accept defer without doing something special). > > Also, we can get rid of the SequencerProcess if we use a mutex to protect > 'last'. Not sure which one is better. > > The discard semantics here is a bit tricky. Basically, I wanna support > discarding a single callback without affecting other callbacks. Also, when > the Sequencer object is deleted, I wanna discard all the pending callbacks. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am a7d199f > 3rdparty/libprocess/include/process/sequence.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/sequence_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17476/diff/ > > > Testing > ------- > > make check > > repeated 1000 times > > > Thanks, > > Jie Yu > >
