> On Feb. 21, 2014, 1:03 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/sequence.hpp, line 124 > > <https://reviews.apache.org/r/17476/diff/4/?file=499673#file499673line124> > > > > this could be named 'addNothing' and the next be 'addCallback' to both > > not require the __ and be more descriptive.
Renamed to 'completed' and 'notified' to be more descriptive. > On Feb. 21, 2014, 1:03 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/sequence.hpp, line 150 > > <https://reviews.apache.org/r/17476/diff/4/?file=499673#file499673line150> > > > > this can move into the initializer section > > > > Sequence::Sequence() : process(new SequenceProcess()) > > { > > process::spawn(process); > > } To be consistent with all other Process wrappers. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17476/#review35118 ----------------------------------------------------------- On Feb. 21, 2014, 9:02 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17476/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 9:02 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > One think I haven't done yet is to make it accepts '_Defer' types. (Just > curious why Future.onAny can accept defer without doing something special). > > Also, we can get rid of the SequencerProcess if we use a mutex to protect > 'last'. Not sure which one is better. > > The discard semantics here is a bit tricky. Basically, I wanna support > discarding a single callback without affecting other callbacks. Also, when > the Sequencer object is deleted, I wanna discard all the pending callbacks. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am a7d199f > 3rdparty/libprocess/include/process/sequence.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/sequence_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17476/diff/ > > > Testing > ------- > > make check > > repeated 1000 times > > > Thanks, > > Jie Yu > >
