----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18339/#review35189 -----------------------------------------------------------
Have you looked at the source code of the open source Mesos frameworks to make sure we won't be breaking them? I seem to recall Chronos or Marathon using ':'. - Ben Mahler On Feb. 21, 2014, 6:21 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18339/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 6:21 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-361 > https://issues.apache.org/jira/browse/MESOS-361 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > It would be good to have specific unit tests for these validators. I could > pull out the validation to another file and add unit tests on them. > > Final validation for TaskID is awaiting consensus (or as close as we can get) > on bug/mailing list. I do prefer to be conservative but I don't want to break > users. > > > Diffs > ----- > > src/master/master.hpp 9d1b56c6b02eb21130f165848297ae0695ac2af7 > src/master/master.cpp cb46869cd298f3a4fcbe8e4e3fea4bb7c741a0e0 > > Diff: https://reviews.apache.org/r/18339/diff/ > > > Testing > ------- > > built. ran make check. ran local master/slave/python framework. > > > Thanks, > > Dominic Hamon > >
