----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18339/#review36316 -----------------------------------------------------------
Ship it! Maybe another patch for ExecutorID validation too? - Vinod Kone On March 4, 2014, 8:42 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18339/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 8:42 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-361 > https://issues.apache.org/jira/browse/MESOS-361 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > It would be good to have specific unit tests for these validators. I could > pull out the validation to another file and add unit tests on them. > > Final validation for TaskID is awaiting consensus (or as close as we can get) > on bug/mailing list. I do prefer to be conservative but I don't want to break > users. > > > Diffs > ----- > > src/master/master.cpp 2e86a1903ce0a0b461eae77078177cc7d28a2659 > > Diff: https://reviews.apache.org/r/18339/diff/ > > > Testing > ------- > > built. ran make check. ran local master/slave/python framework. > > > Thanks, > > Dominic Hamon > >
