> On Feb. 24, 2014, 3:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, lines 23-24 > > <https://reviews.apache.org/r/18383/diff/2/?file=500730#file500730line23> > > > > Why did you need to add these? If the goal was to provide these > > automatically for those including option.hpp, it might be good to spell > > that out here. > > > > Benh added Some and None, can you check with him as to why he didn't > > add these includes implicitly?
I just moved them and changed them from <> to "" as they're not system includes. This will help in terms of readability (figuring out which headers are local to the project) and some build time (minimal but it can help the compiler know which paths to search). > On Feb. 24, 2014, 3:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, lines 100-104 > > <https://reviews.apache.org/r/18383/diff/2/?file=500731#file500731line100> > > > > Perhaps we should make this optimization separately? The error case > > tends to be an exceptional code path, so perhaps we can optimize this > > independently only if there's a need? It doesn't require any changes elsewhere so is a trivial change. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18383/#review35333 ----------------------------------------------------------- On Feb. 24, 2014, 3:57 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18383/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 3:57 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > 3305d1363adfffc5e54ff1617e6e7c3c29f7e200 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > d99b75aeae10319b574c67beeb6023358cac7aec > > Diff: https://reviews.apache.org/r/18383/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
