> On Feb. 24, 2014, 11:42 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp, lines 100-104 > > <https://reviews.apache.org/r/18383/diff/2/?file=500731#file500731line100> > > > > Perhaps we should make this optimization separately? The error case > > tends to be an exceptional code path, so perhaps we can optimize this > > independently only if there's a need? > > Dominic Hamon wrote: > It doesn't require any changes elsewhere so is a trivial change.
Ok, let's just make it in a separate commit at least. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18383/#review35333 ----------------------------------------------------------- On Feb. 24, 2014, 11:57 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18383/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 11:57 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > 3305d1363adfffc5e54ff1617e6e7c3c29f7e200 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > d99b75aeae10319b574c67beeb6023358cac7aec > > Diff: https://reviews.apache.org/r/18383/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
