-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/#review35428
-----------------------------------------------------------
This doesn't apply to master; could you please rebase and update.
{noformat}
[1011][idownes:mesos]$ git fetch origin
[1011][idownes:mesos]$ git status
# On branch master
nothing to commit, working directory clean
[1011][idownes:mesos]$ ./support/apply-review.sh 18403
--2014-02-25 10:11:50-- https://reviews.apache.org/r/18403/diff/raw/
Resolving reviews.apache.org... 140.211.11.74
Connecting to reviews.apache.org|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 29338 (29K) [text/x-patch]
Saving to: ‘18403.patch’
100%[==================================================================================================================================================================================================================================================================================================================================>]
29,338 --.-K/s in 0.05s
2014-02-25 10:11:50 (527 KB/s) - ‘18403.patch’ saved [29338/29338]
error: patch failed: src/slave/slave.hpp:105
error: src/slave/slave.hpp: patch does not apply
Failed to apply patch
{noformat}
- Ian Downes
On Feb. 24, 2014, 7:58 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18403/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 7:58 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes,
> TILL TOENSHOFF, and Vinod Kone.
>
>
> Bugs: MESOS-922
> https://issues.apache.org/jira/browse/MESOS-922
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch delegates the choice of executor to the containerizer by removing
> executorInfo dependencies up until Containerizer::launch().
> Containerizer::launch() now returns a future to the executor info that is
> being run and the slave creates the corresponding executor structure when
> launch completes.
> This means message handling from the running executor to the slave in the
> interim where the executor structure has not created, need to be enqueued
> until executor is ready. So far, registerExecutor() and reregisterExecutor()
> has been split into two continuations to deal with this issue.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp d9ae326
> src/slave/containerizer/mesos_containerizer.hpp ee1fd30
> src/slave/containerizer/mesos_containerizer.cpp 6d990cb
> src/slave/slave.hpp d82d4e9
> src/slave/slave.cpp 7ad8232
> src/tests/containerizer.hpp 5686398
> src/tests/containerizer.cpp bfb9341
>
> Diff: https://reviews.apache.org/r/18403/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Niklas Nielsen
>
>
