-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/
-----------------------------------------------------------
(Updated Feb. 27, 2014, 10:07 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes,
Till Toenshoff, and Vinod Kone.
Changes
-------
Addressed most of Ians comments; introduced a new executor state (LAUNCHING)
and executor::future member to hang pending calls of. Further, killTask has
been split into continuations.
Bugs: MESOS-922
https://issues.apache.org/jira/browse/MESOS-922
Repository: mesos-git
Description
-------
This patch delegates the choice of executor to the containerizer by removing
executorInfo dependencies up until Containerizer::launch().
Containerizer::launch() now returns a future to the executor info that is being
run and the slave creates the corresponding executor structure when launch
completes.
This means message handling from the running executor to the slave in the
interim where the executor structure has not created, need to be enqueued until
executor is ready. So far, registerExecutor() and reregisterExecutor() has been
split into two continuations to deal with this issue.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp d9ae326
src/slave/containerizer/mesos_containerizer.hpp ee1fd30
src/slave/containerizer/mesos_containerizer.cpp 6d990cb
src/slave/http.cpp 594032d
src/slave/slave.hpp 01b80df
src/slave/slave.cpp 4f5349b
src/tests/containerizer.hpp 5686398
src/tests/containerizer.cpp bfb9341
Diff: https://reviews.apache.org/r/18403/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
