----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18341/#review35441 -----------------------------------------------------------
src/master/registrar.cpp <https://reviews.apache.org/r/18341/#comment65961> It seems odd that "apply()" returns None if it's not *mutated*. I would think it makes more sense to return None if it is not *applied*? How about instead of "applied" variable you have a "mutated" that tells whether it is mutated or not? Alternatively s/apply/mutate/ ? src/master/registrar.cpp <https://reviews.apache.org/r/18341/#comment65962> It seems odd that "apply()" returns None if it's not *mutated*. I would think it makes more sense to return None if it is not *applied*? How about instead of "applied" variable you have a "mutated" that tells whether it is mutated or not? Alternatively s/apply/mutate/ ? src/master/registrar.cpp <https://reviews.apache.org/r/18341/#comment65965> Why would this be not empty considering you clear this queue in #335? It also seems odd to me that you pass a copy of "operations" to _update() when you can directly access it? - Vinod Kone On Feb. 21, 2014, 4:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18341/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 4:01 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > We previously were setting the Promises in some cases _before_ writing to > storage. While this approach was correct, it requires some time and > explanation to convince oneself of this. > > This is why this patch simplifies the semantics by only setting the Promises > _after_ we've written to storage. > > Also, 'Mutation' has now become 'Operation' to better reflect the fact that > some operations do not mutate state when applied. > > > Diffs > ----- > > src/master/registrar.cpp 470a40511cf1ac9a379d76a76453df89101d7489 > > Diff: https://reviews.apache.org/r/18341/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
