> On Feb. 25, 2014, 7:49 p.m., Vinod Kone wrote: > > src/master/registrar.cpp, lines 395-397 > > <https://reviews.apache.org/r/18341/diff/1/?file=499800#file499800line395> > > > > Why would this be not empty considering you clear this queue in #335? > > > > It also seems odd to me that you pass a copy of "operations" to > > _update() when you can directly access it?
This is because 'operations' is the incoming queue of operations. Once we begin storing operations, those operations should be excluded from the next batch in update(). Now, the change in this patch is that we need to pass the operations being _applied_ to the _update() continuation so that the Promises can be transitioned. Make sense? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18341/#review35441 ----------------------------------------------------------- On Feb. 21, 2014, 4:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18341/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 4:01 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > We previously were setting the Promises in some cases _before_ writing to > storage. While this approach was correct, it requires some time and > explanation to convince oneself of this. > > This is why this patch simplifies the semantics by only setting the Promises > _after_ we've written to storage. > > Also, 'Mutation' has now become 'Operation' to better reflect the fact that > some operations do not mutate state when applied. > > > Diffs > ----- > > src/master/registrar.cpp 470a40511cf1ac9a379d76a76453df89101d7489 > > Diff: https://reviews.apache.org/r/18341/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
