----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18434/#review35448 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp <https://reviews.apache.org/r/18434/#comment65973> Maybe some parens here for readability? t = (that.t == NULL ? NULL : new T(*that.t)); I realize they are unnecessary but I had to stop and think about this line to consider operator precedence when I first glanced at it. Ditto below. 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp <https://reviews.apache.org/r/18434/#comment65967> I'm hesitant to use fatal() here because fatal exits via exit(1), we won't get a stacktrace if this occurs in mesos. Previously we were using abort(), which results in a SIGABRT and for mesos, SIGABRT results in a nice stacktrace (see logging.cpp for where we set this up). 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp <https://reviews.apache.org/r/18434/#comment65968> Can we make the error() optimization in a separate patch? - Ben Mahler On Feb. 25, 2014, 1:18 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18434/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 1:18 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1008 > https://issues.apache.org/jira/browse/MESOS-1008 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp > 951a1136f0aa7d8ab156c09e76bbae1bc84924a2 > > Diff: https://reviews.apache.org/r/18434/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
