> On Feb. 25, 2014, 7:55 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp, line 112
> > <https://reviews.apache.org/r/18434/diff/3/?file=503046#file503046line112>
> >
> > I'm hesitant to use fatal() here because fatal exits via exit(1), we
> > won't get a stacktrace if this occurs in mesos.
> >
> > Previously we were using abort(), which results in a SIGABRT and for
> > mesos, SIGABRT results in a nice stacktrace (see logging.cpp for where we
> > set this up).
>
> Dominic Hamon wrote:
> any reason not to move fatal() to use abort() then?
>
Sounds good to me, probably best to take that up in a separate patch so we can
clean up the asserts in all of {Try, Result, Option} at once.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18434/#review35448
-----------------------------------------------------------
On Feb. 25, 2014, 9:40 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18434/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 9:40 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1008
> https://issues.apache.org/jira/browse/MESOS-1008
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp
> 951a1136f0aa7d8ab156c09e76bbae1bc84924a2
>
> Diff: https://reviews.apache.org/r/18434/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
