----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18550/#review35644 -----------------------------------------------------------
3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66317> We use <> for headers that would get installed. 3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66278> Let's include the failure too: return Some("is Failed: " + f.failure()); 3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66277> Let's include the failure too: return Some("is Failed: " + f.failure()); 3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66274> Please kill all the white spaces in this file. 3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66276> Let's include the failure too: return Some("is Failed: " + f.failure()); 3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66280> s/PENDING/PROCESS/ 3rdparty/libprocess/include/process/check.hpp <https://reviews.apache.org/r/18550/#comment66279> Kill newline at end of file. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/18550/#comment66325> We're losing information with this, did you want 'CHECK_READY(*this)' instead? 3rdparty/libprocess/include/process/subprocess.hpp <https://reviews.apache.org/r/18550/#comment66340> The 'strings::join' is likely not async signal safe since it does allocation. If you'd like to clean up this code it seems like we need to improve ABORT. One suggestion: provide an overload to '_abort' which takes 10 const char* parameters with defaults set to NULL, then be able to do: ABORT("Failed to execl '/bin/sh -c ", command.c_str(), "'\n"); Also, please kill the whitespace here. - Benjamin Hindman On Feb. 27, 2014, 12:30 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18550/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 12:30 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1041 > https://issues.apache.org/jira/browse/MESOS-1041 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am a7d199f6b90fee0927ac33351939ddaf2e5a2f6a > 3rdparty/libprocess/include/process/check.hpp PRE-CREATION > 3rdparty/libprocess/include/process/collect.hpp > 2a73bc946fc4fa65229e9c979d841f2657a7cd2d > 3rdparty/libprocess/include/process/future.hpp > e45f4f79faeefbffc28d855d2f74e8df69099f18 > 3rdparty/libprocess/include/process/subprocess.hpp > 452eeeae0a9f2353db2d9302be594a578db52026 > > Diff: https://reviews.apache.org/r/18550/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
