> On Feb. 27, 2014, 11:03 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 151-152 > > <https://reviews.apache.org/r/18550/diff/1/?file=505253#file505253line151> > > > > The 'strings::join' is likely not async signal safe since it does > > allocation. If you'd like to clean up this code it seems like we need to > > improve ABORT. One suggestion: provide an overload to '_abort' which takes > > 10 const char* parameters with defaults set to NULL, then be able to do: > > > > ABORT("Failed to execl '/bin/sh -c ", command.c_str(), "'\n"); > > > > Also, please kill the whitespace here. > >
wouldn't i have to do something like http://stackoverflow.com/questions/3046889/optional-parameters-with-c-macros ? maybe in this case it's better to lose the information and just abort with 'failed to execl'. maybe log the command attempt to info before the attempt? - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18550/#review35644 ----------------------------------------------------------- On Feb. 27, 2014, 11:18 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18550/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 11:18 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1041 > https://issues.apache.org/jira/browse/MESOS-1041 > > > Repository: mesos-git > > > Description > ------- > > see summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am a7d199f6b90fee0927ac33351939ddaf2e5a2f6a > 3rdparty/libprocess/include/process/check.hpp PRE-CREATION > 3rdparty/libprocess/include/process/collect.hpp > 2a73bc946fc4fa65229e9c979d841f2657a7cd2d > 3rdparty/libprocess/include/process/future.hpp > e45f4f79faeefbffc28d855d2f74e8df69099f18 > 3rdparty/libprocess/include/process/subprocess.hpp > 452eeeae0a9f2353db2d9302be594a578db52026 > > Diff: https://reviews.apache.org/r/18550/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
