> On Feb. 28, 2014, 7:59 p.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.cpp, line 334 > > <https://reviews.apache.org/r/18639/diff/1/?file=507087#file507087line334> > > > > Let's make a cpu::cfs_period_us wrapper like we did for the mem > > controls!
will do these in a subsequent review. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18639/#review35830 ----------------------------------------------------------- On Feb. 28, 2014, 7:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18639/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 7:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1049 > https://issues.apache.org/jira/browse/MESOS-1049 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 160e8fe5eb06a2f65924734157b7b8d468d8be36 > > Diff: https://reviews.apache.org/r/18639/diff/ > > > Testing > ------- > > Verified manually by changing the cpu shares to 13.5 in > LimitedCpuIsolatorTest. > > Didn't change the test in this diff because I want to come up with a test > that runs for all users and doesn't take too much time. > > > Thanks, > > Vinod Kone > >
