----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18642/#review35845 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/18642/#comment66618> what happens if shares > 1024? My understanding is the default is the total is 1024 so setting this to 100 would give ~10%. Should we bounds check? src/linux/cgroups.cpp <https://reviews.apache.org/r/18642/#comment66619> uint64_t? or do you expect negative values? - Dominic Hamon On Feb. 28, 2014, 12:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18642/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 12:55 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7 > src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 160e8fe5eb06a2f65924734157b7b8d468d8be36 > > Diff: https://reviews.apache.org/r/18642/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
