> On Feb. 28, 2014, 9:01 p.m., Dominic Hamon wrote: > > src/linux/cgroups.cpp, line 1958 > > <https://reviews.apache.org/r/18642/diff/1/?file=507098#file507098line1958> > > > > what happens if shares > 1024? My understanding is the default is the > > total is 1024 so setting this to 100 would give ~10%. Should we bounds > > check?
there is no upper limit per kernel docs. but if the kernel doesn't like it it would give an error. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18642/#review35845 ----------------------------------------------------------- On Feb. 28, 2014, 8:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18642/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 8:55 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.hpp 2f4ab256a5cee6a416b353316f6bd4eeec4f95f7 > src/linux/cgroups.cpp 4bf7f26ce96b96b91ebe653b31fa9c27a9ee0a21 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 160e8fe5eb06a2f65924734157b7b8d468d8be36 > > Diff: https://reviews.apache.org/r/18642/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
