----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18700/#review36057 -----------------------------------------------------------
Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp <https://reviews.apache.org/r/18700/#comment66887> this CR reads like picoJSON is an implementation detail of stout::JSON - is that the long term plan? or do we want to switch to picoJSON and remove stout::JSON eventually? if it's the later, then you should probably make these guys public so calling code can switch over to picoJSON incrementally - Charlie Carson On March 3, 2014, 6:50 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18700/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 6:50 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 778398af0e166709a777d770b7fddda309a60add > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 5b7cbb9b42aaa0dc4f3e732d4ceae496bcb15ea6 > > Diff: https://reviews.apache.org/r/18700/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
