> On March 4, 2014, midnight, Charlie Carson wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 352 > > <https://reviews.apache.org/r/18700/diff/1/?file=508464#file508464line352> > > > > this CR reads like picoJSON is an implementation detail of stout::JSON > > - is that the long term plan? or do we want to switch to picoJSON and > > remove stout::JSON eventually? > > > > if it's the later, then you should probably make these guys public so > > calling code can switch over to picoJSON incrementally
We're going to keep a level of indirection for now. There are things that PicoJSON doesn't support that we'll be adding (like JSON::Object::find, see an upcoming review) so it's nice to have a layer of indirection. That and if in the future we decide that PicoJSON parsing (or serializing, if we use that) is too slow we can easily swap it for something like yajl or RapidJSON. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18700/#review36057 ----------------------------------------------------------- On March 3, 2014, 6:50 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18700/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 6:50 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 778398af0e166709a777d770b7fddda309a60add > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 5b7cbb9b42aaa0dc4f3e732d4ceae496bcb15ea6 > > Diff: https://reviews.apache.org/r/18700/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
