----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18676/#review35986 -----------------------------------------------------------
Ship it! Awesome, looking forward to getting this running! support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66773> s/Reviewboard/Review Board/ support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66933> What about getting the password from the command line? Then the Jenkins bot can be configured with the password but what the "public" sees in the description box (or what ever it's called) would just be #####. support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66774> We should really be moving to using the PEP 8 style guide, which is +4 indent. support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66935> Spaces. support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66934> Could we always delete the patch file (like apply-review.sh) in case someone uses this locally? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66936> Why not s/url/href/ instead? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66937> What about defining the 'api' function above this usage? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66938> . support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66939> Move 'post_review' above too? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66940> Also s/url/href/ here? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66945> Newline before this? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66946> Spaces. support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66947> Is 'not' here really better than '= 0'? support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66948> Spaces (equals and after comma). support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66950> Spaces. support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66951> Spaces (equals and after comma). support/verify-reviews.py <https://reviews.apache.org/r/18676/#comment66942> s/mesos/Mesos/ - Benjamin Hindman On March 3, 2014, 7:33 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18676/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 7:33 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1052 > https://issues.apache.org/jira/browse/MESOS-1052 > > > Repository: mesos-git > > > Description > ------- > > Created a RB account for the ReviewBot so that it can post reviews. > > > Diffs > ----- > > support/verify-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18676/diff/ > > > Testing > ------- > > Verified (:)) by slightly modifying the script and testing on the following > review. > > https://reviews.apache.org/r/18674/ > > > Thanks, > > Vinod Kone > >
