> On March 4, 2014, 1:33 a.m., Benjamin Hindman wrote: > > support/verify-reviews.py, lines 32-34 > > <https://reviews.apache.org/r/18676/diff/2/?file=507878#file507878line32> > > > > Could we always delete the patch file (like apply-review.sh) in case > > someone uses this locally?
"git clean -fd" at the end of verify_review should clean the patch up. > On March 4, 2014, 1:33 a.m., Benjamin Hindman wrote: > > support/verify-reviews.py, line 43 > > <https://reviews.apache.org/r/18676/diff/2/?file=507878#file507878line43> > > > > Why not s/url/href/ instead? the json doesn't contain url unfortunately. > On March 4, 2014, 1:33 a.m., Benjamin Hindman wrote: > > support/verify-reviews.py, line 79 > > <https://reviews.apache.org/r/18676/diff/2/?file=507878#file507878line79> > > > > Also s/url/href/ here? json doesn't contain url. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18676/#review35986 ----------------------------------------------------------- On March 3, 2014, 7:33 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18676/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 7:33 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1052 > https://issues.apache.org/jira/browse/MESOS-1052 > > > Repository: mesos-git > > > Description > ------- > > Created a RB account for the ReviewBot so that it can post reviews. > > > Diffs > ----- > > support/verify-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/18676/diff/ > > > Testing > ------- > > Verified (:)) by slightly modifying the script and testing on the following > review. > > https://reviews.apache.org/r/18674/ > > > Thanks, > > Vinod Kone > >
