> On March 3, 2014, 11:36 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 355-356 > > <https://reviews.apache.org/r/18701/diff/1/?file=508466#file508466line355> > > > > Why is this checking for TYPE_STRING/TYPE_BYTES and not TYPE_BOOL? > > Benjamin Hindman wrote: > Ahhh! This bug wasn't caught in the test because apparently bmahler's > original tests didn't include a protobuf message with bools. I'll fix both > the message and the tests. THANK YOU! > > Benjamin Hindman wrote: > I put this all in https://reviews.apache.org/r/18724. > > Vinod Kone wrote: > Can you do the fix in this review? I'm ok with adding boolean tests in > the new (18724) review but it seems odd that the fix for a bug introduced in > this review is being fixed in another one.
Included the fix in the latest diff. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18701/#review36046 ----------------------------------------------------------- On March 4, 2014, 5:39 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18701/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 5:39 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 74aec7a5645697e578f64c9432d6e9990340da25 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > 02bbf749c6f0aa190214b616799e246400ce5397 > > Diff: https://reviews.apache.org/r/18701/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
