> On March 3, 2014, 7:04 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 414 > > <https://reviews.apache.org/r/18701/diff/1/?file=508466#file508466line414> > > > > Is this ever anything other than protobuf::Message?
There should not be, thus we do a "type check" at the top of the function. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18701/#review36007 ----------------------------------------------------------- On March 4, 2014, 5:39 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18701/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 5:39 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 74aec7a5645697e578f64c9432d6e9990340da25 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > 02bbf749c6f0aa190214b616799e246400ce5397 > > Diff: https://reviews.apache.org/r/18701/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
