----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review36455 -----------------------------------------------------------
Before I dive too deep into this review, can you give an overview of your proposed next steps? In particular: (1) What's the concurrency story here? It appears as though multiple actors adding or removing metrics could causing conflicting writes and reads. (2) How do you plan on exposing the JSON data as a REST endpoint? (3) Do you plan to integrate into libprocess statistics? Were you thinking of changing the name of libprocess statistics to metrics? The advantage of using statistics is that you'll have solved (1) and you'll get time series that can be useful for people wanting to plot things without needing some other place to store the metrics. - Benjamin Hindman On March 4, 2014, 6:50 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 6:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4 > src/metrics/counter.hpp PRE-CREATION > src/metrics/gauge.hpp PRE-CREATION > src/metrics/metric.hpp PRE-CREATION > src/metrics/metric.cpp PRE-CREATION > src/metrics/metrics.hpp PRE-CREATION > src/metrics/metrics.cpp PRE-CREATION > src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
