----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review36481 -----------------------------------------------------------
Patch looks great! Reviews applied: [18718] All tests passed. - Mesos ReviewBot On March 4, 2014, 6:50 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 6:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am 61d832b89132be2cc5b8ae9bbf743685464f78a4 > src/metrics/counter.hpp PRE-CREATION > src/metrics/gauge.hpp PRE-CREATION > src/metrics/metric.hpp PRE-CREATION > src/metrics/metric.cpp PRE-CREATION > src/metrics/metrics.hpp PRE-CREATION > src/metrics/metrics.cpp PRE-CREATION > src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
