> On March 9, 2014, 9:34 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [18946] > > > > Failed command: make -j3 check GTEST_FILTER='' >/dev/null > > > > Error: > > ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared > > 'extern' [enabled by default] > > ev.c: In function 'evpipe_write': > > ev.c:2160:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2172:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c: In function 'pipecb': > > ev.c:2193:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2207:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/c++/4.6/ext/hash_set:61:0, > > from src/glog/stl_logging.h:54, > > from src/stl_logging_unittest.cc:34: > > /usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning > > This file includes at least one deprecated or antiquated header which may > > be removed without further notice at a future date. Please use a > > non-deprecated interface with equivalent functionality instead. For a > > listing of replacement headers and interfaces, consult the file > > backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp] > > In file included from src/utilities.h:73:0, > > from src/googletest.h:38, > > from src/stl_logging_unittest.cc:48: > > src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by > > default] > > /usr/include/features.h:166:0: note: this is the location of the previous > > definition > > warning: no files found matching 'Makefile' under directory 'docs' > > warning: no files found matching 'indexsidebar.html' under directory 'docs' > > zip_safe flag not set; analyzing archive contents... > > /usr/bin/ld: cannot find -lmesos > > collect2: ld returned 1 exit status > > make[2]: *** [libmesos_java.la] Error 1 > > make[2]: *** Waiting for unfinished jobs.... > > make[1]: *** [check] Error 2 > > make: *** [check-recursive] Error 1 > >
Whoops, failed to see that my initial version only worked because I had libmesos installed previously. Fix upcoming... - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18946/#review36617 ----------------------------------------------------------- On March 9, 2014, 7 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18946/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 7 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-855 > https://issues.apache.org/jira/browse/MESOS-855 > > > Repository: mesos-git > > > Description > ------- > > Introduced a new environment variable (MESOS_NATIVE_JAVA_LIBRARY). That > variable points towards libmesos_java. libmesos_java contains the JNI- > specific code (formally part of libmesos) and dynamically links against > libmesos. > > A typical java-based framework relies on mesos.jar to do the loading > but may use some extra logic in its startup to make sure > MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic would need > to be adapted to use the new environment variable instead of the old > one. > > > Diffs > ----- > > bin/mesos-slave-flags.sh.in dc73aef > src/Makefile.am 61d832b > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2 > > Diff: https://reviews.apache.org/r/18946/diff/ > > > Testing > ------- > > make check and functional testing with external, java based frameworks > > > Thanks, > > Till Toenshoff > >
