----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18946/#review36668 -----------------------------------------------------------
As you mentioned in the JIRA; this will have consequences for Java frameworks. Would it make sense to introduce two new environment variables and maintain the old one for backward compatibility? src/Makefile.am <https://reviews.apache.org/r/18946/#comment67711> Fix spaces/tabs :) - Niklas Nielsen On March 9, 2014, 8:27 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18946/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 8:27 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-855 > https://issues.apache.org/jira/browse/MESOS-855 > > > Repository: mesos-git > > > Description > ------- > > Introduced a new environment variable (MESOS_NATIVE_JAVA_LIBRARY). That > variable points towards libmesos_java. libmesos_java contains the JNI- > specific code (formally part of libmesos) and dynamically links against > libmesos. > > A typical java-based framework relies on mesos.jar to do the loading > but may use some extra logic in its startup to make sure > MESOS_NATIVE[_JAVA]_LIBRARY is set/valid. That extra-logic would need > to be adapted to use the new environment variable instead of the old > one. > > > Diffs > ----- > > bin/mesos-slave-flags.sh.in dc73aef > src/Makefile.am 384b312 > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in 231d1e2 > > Diff: https://reviews.apache.org/r/18946/diff/ > > > Testing > ------- > > make check and functional testing with external, java based frameworks > > > Thanks, > > Till Toenshoff > >
