----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18952/#review36656 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/18952/#comment67690> While we are writing to associated under lock, we aren't reading under lock. Should lock be a rwlock? or should this be read/written under RCU semantics? Apologies if I'm missing something about how Promise is implemented that makes this unnecessary. - Dominic Hamon On March 10, 2014, 1:03 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18952/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 1:03 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > In particular, doing associations is strictly safer now. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 > > Diff: https://reviews.apache.org/r/18952/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
