> On March 14, 2014, 11:26 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/future.hpp, lines 639-646 > > <https://reviews.apache.org/r/18952/diff/2/?file=515326#file515326line639> > > > > It looks like these reads have a race with the associate() method for > > the reasons Dominic mentioned. > > Benjamin Hindman wrote: > Given the current way Promise and Future work, it's effectively > impossible to eliminate this race. I'm going to rename this review to just > specify that we've added 'associate' but not fully made Promise be > thread-safe. Adding associate is still a nice step that I'll use in a future > review that makes Promise fully thread-safe (which will be much more > disruptive).
Ok, renaming the review summary sounds good. Would be great to have a TODO that reflects this issue as well. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18952/#review37286 ----------------------------------------------------------- On March 10, 2014, 7:18 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18952/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 7:18 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > In particular, doing associations is strictly safer now. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 27b0970bf1d1ae1b977ddfc2de5ee858f1031bf5 > > Diff: https://reviews.apache.org/r/18952/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
