----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18977/#review36685 -----------------------------------------------------------
Ship it! src/tests/registrar_tests.cpp <https://reviews.apache.org/r/18977/#comment67739> do you want to use protobuf::createMasterInfo()? - Vinod Kone On March 10, 2014, 6:53 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18977/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 6:53 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1077 > https://issues.apache.org/jira/browse/MESOS-1077 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-1077. MasterInfo has required fields and some of the tests were not > setting them. > > > Diffs > ----- > > src/tests/registrar_tests.cpp 8620e8a5c06b77c7a4ae56308436eb24af90bf6b > > Diff: https://reviews.apache.org/r/18977/diff/ > > > Testing > ------- > > make check with 50 repetitions > > > Thanks, > > Ben Mahler > >
