> On March 10, 2014, 6:57 p.m., Dominic Hamon wrote: > > src/tests/registrar_tests.cpp, line 53 > > <https://reviews.apache.org/r/18977/diff/1/?file=515319#file515319line53> > > > > you could initialize the master in the constructor.
Originally I couldn't do this because I would then want master to be 'const', now that I have createMasterInfo() I can use the copy constructor and have a 'const' 'master'. There are some tests that create mutable data in the constructor, which I was originally trying to avoid in this case (see paths_tests.cpp). But I'd like to stick with a fresh mutable master per test, since I can envision recovery tests that will want to re-assign 'master' without affecting other tests. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18977/#review36686 ----------------------------------------------------------- On March 10, 2014, 6:53 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18977/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 6:53 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1077 > https://issues.apache.org/jira/browse/MESOS-1077 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-1077. MasterInfo has required fields and some of the tests were not > setting them. > > > Diffs > ----- > > src/tests/registrar_tests.cpp 8620e8a5c06b77c7a4ae56308436eb24af90bf6b > > Diff: https://reviews.apache.org/r/18977/diff/ > > > Testing > ------- > > make check with 50 repetitions > > > Thanks, > > Ben Mahler > >
