----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18966/#review36793 -----------------------------------------------------------
src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/18966/#comment67981> Looks like you can remove this TODO src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/18966/#comment67982> it's being cast to size_t here, so you may lose precision on a 32-bit machine. Though if we have > 2^32 shares... perhaps instead we should make it a uint32_t and be done with it. Do make sure to follow the type change through everywhere it is used. - Dominic Hamon On March 10, 2014, 11:17 p.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18966/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 11:17 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > I intend to change the datatype of cpushare from size_t to uint64_t because > The actual type of size_t is platform-dependent > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.cpp f74e80e > > Diff: https://reviews.apache.org/r/18966/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
