> On March 11, 2014, 6:07 p.m., Ben Mahler wrote: > > src/slave/containerizer/isolators/cgroups/cpushare.cpp, lines 60-61 > > <https://reviews.apache.org/r/18966/diff/1/?file=515048#file515048line60> > > > > Please be sure to update the places where these are used as well as the > > argument type in cgroups::cpu::shares().
Hey Archana, it doesn't look like you've updated cgroups::cpu::shares in your latest diff. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18966/#review36820 ----------------------------------------------------------- On March 11, 2014, 9:36 p.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18966/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 9:36 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > I intend to change the datatype of cpushare from size_t to uint64_t because > The actual type of size_t is platform-dependent > > > Diffs > ----- > > src/slave/containerizer/isolators/cgroups/cpushare.cpp f74e80e > > Diff: https://reviews.apache.org/r/18966/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
