----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19007/#review36798 -----------------------------------------------------------
src/state/log.cpp <https://reviews.apache.org/r/19007/#comment67989> why list over vector? vector is going to be more cache friendly even if you don't need random access. src/state/log.cpp <https://reviews.apache.org/r/19007/#comment67988> whitespace src/state/log.cpp <https://reviews.apache.org/r/19007/#comment67993> const hashset<string>& keys = snapshots.keys(); return vector<string>(keys.begin(), keys.end()); might be shorter and more efficient. src/state/log.cpp <https://reviews.apache.org/r/19007/#comment67994> you don't need the process:: src/tests/log_tests.cpp <https://reviews.apache.org/r/19007/#comment67995> remove the newline to avoid having any diffs in this file? - Dominic Hamon On March 10, 2014, 7:53 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19007/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 7:53 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > This is a combination of both https://reviews.apache.org/r/17423 and > https://reviews.apache.org/r/17424 which have been merged to make it easier > to make changes. > > > Diffs > ----- > > src/Makefile.am 384b3122b61294401ba4a894c06e985d9fc2fb1e > src/messages/state.proto 7f7a8a505d6f24b01fec0c3ad47b0e15b2b17ffa > src/state/log.hpp PRE-CREATION > src/state/log.cpp PRE-CREATION > src/tests/log_tests.cpp b368cdec6a81a8ddeb6fc14d4723a09797a6b0a1 > src/tests/state_tests.cpp bc6c91439a50e7b93077f5b1e66b0419860cb35b > > Diff: https://reviews.apache.org/r/19007/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
