----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19184/#review37060 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/19184/#comment68315> this definition doesn't match the declaration. Did you build this patch? 1. there's no return value. 2. you have strings passed by value rather than const reference (as they are in the declaration. src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/19184/#comment68316> This doesn't really add anything as you still have the repetition in the hierarchies lookup. Perhaps the methods should take the entire hierarchy as a parameter instead? Then this would be: stat = cgroups::cpuacct::stat(heirarchies, info->cgroup); - Dominic Hamon On March 13, 2014, 4:42 a.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19184/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 4:42 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Fixed a issue related to Jira 1076 > > > Diffs > ----- > > src/linux/cgroups.hpp 65f0958 > src/linux/cgroups.cpp 6f95376 > src/slave/containerizer/isolators/cgroups/cpushare.cpp f74e80e > src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e > > Diff: https://reviews.apache.org/r/19184/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
