----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19184/#review37231 -----------------------------------------------------------
Hey Archana, remember that the point of the TODO was to return a 'struct' of the expected information so that callers don't have to guess which keys are present in the hashmap. Looking forward to your update! src/slave/containerizer/isolators/cgroups/cpushare.cpp <https://reviews.apache.org/r/19184/#comment68650> This is still returning a hashmap, it would be nice if this returned a cgroups::cpuacct::Stat struct that contains the expected information. Ditto for memory. - Ben Mahler On March 13, 2014, 9:41 p.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19184/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 9:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Fixed a issue related to Jira 1076 > > > Diffs > ----- > > src/linux/cgroups.hpp 65f0958 > src/linux/cgroups.cpp 6f95376 > src/slave/containerizer/isolators/cgroups/cpushare.cpp f74e80e > src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e > > Diff: https://reviews.apache.org/r/19184/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
