----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18966/#review37262 -----------------------------------------------------------
Ship it! Thanks Archana! I'll be committing this patch. It looks like you still have some open issues on this review, but you've fixed them in your new diffs. Can you mark them 'Fixed'? - Ben Mahler On March 14, 2014, 7:51 p.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18966/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 7:51 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > I intend to change the datatype of cpushare from size_t to uint64_t because > The actual type of size_t is platform-dependent > > > Diffs > ----- > > src/linux/cgroups.hpp 65f0958 > src/linux/cgroups.cpp 6f95376 > src/slave/containerizer/isolators/cgroups/cpushare.cpp f74e80e > > Diff: https://reviews.apache.org/r/18966/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > >
