----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19248/#review37342 -----------------------------------------------------------
Patch looks great! Reviews applied: [19248] All tests passed. - Mesos ReviewBot On March 15, 2014, 12:50 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19248/ > ----------------------------------------------------------- > > (Updated March 15, 2014, 12:50 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-327 > https://issues.apache.org/jira/browse/MESOS-327 > > > Repository: mesos-git > > > Description > ------- > > This functionality is intended to support monitoring of the slave's > resources, specifically memory and cpu. This is done by moving the slave into > a cpuacct and memory cgroup under > $cgroups_hierarchy/{cpuacct,memory}/$cgroups_root/slave. > > cgroup statistics will be of the slave itself plus any child process that > isn't moved to another cgroup, e.g., mesos-fetcher will be accounted but > executors will not. > > > Diffs > ----- > > src/slave/flags.hpp c9a627bc405a48da5d5ef9a90355970151fd6149 > src/slave/main.cpp 8c2b70cb864b268ebd7fba89b02a571602b821bb > > Diff: https://reviews.apache.org/r/19248/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
