-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19248/#review37586
-----------------------------------------------------------
Bad patch!
Reviews applied: [19248]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
slave/slave.cpp: In member function 'virtual void
mesos::internal::slave::Slave::initialize()':
slave/slave.cpp:179:31: error: 'tids' is not a member of 'proc'
make[2]: *** [slave/libmesos_no_3rdparty_la-slave.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 18, 2014, 5:58 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19248/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 5:58 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-327
> https://issues.apache.org/jira/browse/MESOS-327
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This functionality is intended to support monitoring of the slave's
> resources, specifically memory and cpu. This is done by moving the slave into
> a cpuacct and memory cgroup under
> $cgroups_hierarchy/{cpuacct,memory}/$cgroups_root/slave.
>
> cgroup statistics will be of the slave itself plus any child process that
> isn't moved to another cgroup, e.g., mesos-fetcher will be accounted but
> executors will not.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am
> df149ddc8669b0c541361922631f4f3958bd096d
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
> 901e5550c82c12934a6b9c3154f030c677e41a38
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp
> ba8463cc152701d6eb1deba8d1561688ecf5b7b5
> bin/mesos-slave-flags.sh.in 8c936aa06e994a87a8b09b31c907868bf9be38c7
> configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a
> docs/getting-started.md d7ced76125c6aba0d7e1a0f4ca8165652b17af0d
> src/Makefile.am 0775a0df293e945d41c7ba90fd1bbb503ae22f9e
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in
> 668647fdfc0e203fcde59263256659ba14e29960
> src/linux/cgroups.hpp 6056e3ae59ed813d75b1bb46b276872530155ec7
> src/linux/cgroups.cpp eff15af417f3827b4a1f73770b98dc9fccbc397e
> src/local/local.cpp 2cfdf49c9eb92302502eb50c623f9606977b88b6
> src/master/detector.cpp 8b10061de12a35ad6624db594dc4ec36502b2420
> src/master/flags.hpp 024f86d93824a20ce42c28b8264576f1cb715d0e
> src/master/http.cpp 72d8e91013cd6a9c52a6d1ffdf517a52c4567bb7
> src/master/main.cpp f12f20a1eabd163c4f35056bf01f28f3edd408a9
> src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7
> src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437
> src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c
> src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1
> src/slave/containerizer/containerizer.cpp
> faf3d0cf97aafd88eab82ae39e2255b1eb4ce294
> src/slave/containerizer/isolators/cgroups/cpushare.cpp
> 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/flags.hpp c9a627bc405a48da5d5ef9a90355970151fd6149
> src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54
> src/tests/cluster.hpp 40d9f8c18307aead2374396710f9a82466e3a716
> src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90
> src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e
> src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145
>
> Diff: https://reviews.apache.org/r/19248/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
