> On March 16, 2014, 10:38 p.m., Adam B wrote: > > include/mesos/mesos.proto, line 515 > > <https://reviews.apache.org/r/18730/diff/4/?file=520216#file520216line515> > > > > What is 'principals' supposed to represent here? Slaves? So that slave1 > > and slave2 are allocatable_to a particular role (e.g. marketing)? Maybe > > 'principals' should be named something more explicit. > > Vinod Kone wrote: > 'principal' is the framework principal that we have authenticated. See > "Credential.Principal". > > This is essentially saying which framework principals get resource offers > for a certain resource reservation role. See the JSON above for an example.
Yes, but after my Slave authentication patch lands, a Credential.Principal could represent a framework or a slave (I just remembered to update the comment for Credential in mesos.proto). A little clarification on what kind of principal is expected here would be helpful. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review37339 ----------------------------------------------------------- On March 17, 2014, 5:13 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 5:13 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > df149ddc8669b0c541361922631f4f3958bd096d > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > 47fe92c380de3e2abc625dc936afbd034280b76a > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 901e5550c82c12934a6b9c3154f030c677e41a38 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/permissions.hpp > ba8463cc152701d6eb1deba8d1561688ecf5b7b5 > 3rdparty/libprocess/include/process/future.hpp > 5e124760ca304082da506c91b6341e784f103d93 > bin/mesos-slave-flags.sh.in 8c936aa06e994a87a8b09b31c907868bf9be38c7 > configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a > docs/getting-started.md d7ced76125c6aba0d7e1a0f4ca8165652b17af0d > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am 0775a0df293e945d41c7ba90fd1bbb503ae22f9e > src/authorizer/authorizer.hpp PRE-CREATION > src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in > 668647fdfc0e203fcde59263256659ba14e29960 > src/linux/cgroups.hpp 6056e3ae59ed813d75b1bb46b276872530155ec7 > src/linux/cgroups.cpp eff15af417f3827b4a1f73770b98dc9fccbc397e > src/linux/fs.hpp ac8b5f416dae0a9388a3839b6f078abdcd42edae > src/linux/fs.cpp b01d14c3a1b296566b2b17a7f540097bd7cc53dd > src/local/local.cpp 2cfdf49c9eb92302502eb50c623f9606977b88b6 > src/log/log.cpp d9b26871bfa1b3c36f5e7d879eb7b67132af1b33 > src/master/flags.hpp 024f86d93824a20ce42c28b8264576f1cb715d0e > src/master/http.cpp 72d8e91013cd6a9c52a6d1ffdf517a52c4567bb7 > src/master/main.cpp f12f20a1eabd163c4f35056bf01f28f3edd408a9 > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/sched/sched.cpp 3684cfe9d153cab5f4ea86094fffd814ce74baa1 > src/slave/containerizer/containerizer.cpp > faf3d0cf97aafd88eab82ae39e2255b1eb4ce294 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 11665dbe88e3920fd9d8a2259987611d49e85462 > src/slave/containerizer/mesos_containerizer.cpp > c819c97d96d232a1de3c1ed2fc848bebf66981f7 > src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54 > src/slave/status_update_manager.cpp > 5d5cf234ef2dd47fa4b1f67be761dbca31659451 > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/cluster.hpp 40d9f8c18307aead2374396710f9a82466e3a716 > src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90 > src/tests/master_contender_detector_tests.cpp > 8da7420e18c7a960b566fae13a5975857eb777ee > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > src/tests/state_tests.cpp d0e084070c566ee7d751a8e1279772e05b966145 > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
