----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18730/#review37442 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/18730/#comment68976> why isn't this just a repeated string? src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment68977> explicit src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment68979> does this need to be in the header? If so, does the implementation of the constructor need to be inline? src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment68978> explicit src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment68980> this is heavily tied to the protocol buffer structure. Is there any way you can use reflection to build this cache? src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment68981> some of these might be better as WARNING src/authorizer/authorizer.hpp <https://reviews.apache.org/r/18730/#comment68982> do you think it's worth validating in the Process when you're building the hashmaps, or have you split this into two phase on purpose? - Dominic Hamon On March 14, 2014, 5:45 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18730/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 5:45 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Bugs: MESOS-911 > https://issues.apache.org/jira/browse/MESOS-911 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > src/Makefile.am ce7913be8432290a01fdcdede0fb9b5233745031 > src/authorizer/authorizer.hpp PRE-CREATION > src/tests/authorization_tests.cpp PRE-CREATION > src/tests/master_contender_detector_tests.cpp > 8da7420e18c7a960b566fae13a5975857eb777ee > > Diff: https://reviews.apache.org/r/18730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
