> On March 19, 2014, 5:27 p.m., Jiang Yan Xu wrote: > > src/master/registrar.hpp, line 181 > > <https://reviews.apache.org/r/19372/diff/3/?file=528110#file528110line181> > > > > When the API was like: remove(const SlaveInfo&) we had the ability to > > overload the methods for other data types. e.g. > > remove(const FrameworkInfo&) > > > > Now we have lost it. What if in the future we want a 'Remove' for > > something else? > > > > Should we rename it to RemoveSlave? > > > > Ditto for Admit & Readmit.
Changing the names make sense, and also moving the implementations from registrar.hpp into master.cpp might make sense as well (as these are master specific registrar operations. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19372/#review37739 ----------------------------------------------------------- On March 19, 2014, 5:21 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19372/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 5:21 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1112 > https://issues.apache.org/jira/browse/MESOS-1112 > > > Repository: mesos-git > > > Description > ------- > > For initial feedback. > > > Diffs > ----- > > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > > Diff: https://reviews.apache.org/r/19372/diff/ > > > Testing > ------- > > make check GTEST_FILTER=*Registrar* > > > Thanks, > > Jiang Yan Xu > >
