> On March 19, 2014, 10:27 a.m., Jiang Yan Xu wrote: > > src/master/registrar.hpp, lines 42-43 > > <https://reviews.apache.org/r/19372/diff/3/?file=528110#file528110line42> > > > > To make it less annoying to call the APIs with all the template > > parameters, i.e. `apply(Owned<Operation<Registry> > > operation)`, can we > > not make this a template? > > > > AFAICT, this Operation is only intended for the "Registrar" hence I > > can't see it work with anything other than the "Registry".
Further to this - why does Operation inherit from Promise? Could it use composition instead? - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19372/#review37739 ----------------------------------------------------------- On March 19, 2014, 5:12 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19372/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 5:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1112 > https://issues.apache.org/jira/browse/MESOS-1112 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > > Diff: https://reviews.apache.org/r/19372/diff/ > > > Testing > ------- > > make check GTEST_FILTER=*Registrar* > > > Thanks, > > Jiang Yan Xu > >
