> On March 19, 2014, 12:45 p.m., Vinod Kone wrote: > > src/slave/slave.hpp, line 440 > > <https://reviews.apache.org/r/18403/diff/5/?file=522998#file522998line440> > > > > Why do we need this? > > > > Why not just set Executor::id appropriately in the constructor? > > > > Niklas Nielsen wrote: > Good point!
We need the id before we have an executor structure; created in Framework::launch() which is called in _runTask() and we already need it in runTask() > On March 19, 2014, 12:45 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 588 > > <https://reviews.apache.org/r/18403/diff/5/?file=522999#file522999line588> > > > > Why is this a CHECK? What guarantees that the executor info is set when > > we are here? Actually, several executor infos might be in flight when a reregistration happens; we will need to split reregistration in two and do a collect().onAny() on them. How does that sound? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18403/#review37753 ----------------------------------------------------------- On March 20, 2014, 9:53 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18403/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 9:53 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This patch delegates the choice of executor to the containerizer by removing > executorInfo dependencies up until Containerizer::launch(). > Containerizer::launch() now returns a future to the executor info that is > being run and the slave creates the corresponding executor structure when > launch completes. > This means message handling from the running executor to the slave in the > interim where the executor structure has not created, need to be enqueued > until executor is ready. So far, registerExecutor() and reregisterExecutor() > has been split into two continuations to deal with this issue. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp d9ae326 > src/slave/containerizer/mesos_containerizer.hpp ee1fd30 > src/slave/containerizer/mesos_containerizer.cpp c819c97 > src/slave/http.cpp 594032d > src/slave/slave.hpp 01b80df > src/slave/slave.cpp d8d3e0f > src/tests/containerizer.hpp 5686398 > src/tests/containerizer.cpp bfb9341 > src/tests/gc_tests.cpp ac547cf > > Diff: https://reviews.apache.org/r/18403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
