-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18403/
-----------------------------------------------------------
(Updated March 21, 2014, 10:15 a.m.)
Review request for mesos, Ian Downes and Vinod Kone.
Changes
-------
A container might be launching during reregistration and thus, the
executor->info may not be ready and shouldn't cause the slave to fail
(CHECK(executor->info.isReady()). doReliableReregistration has been split in
two; the upper half does a collect on all executor->info's and second half
sends reregistration message to master.
Split is coming up.
Bugs: MESOS-922
https://issues.apache.org/jira/browse/MESOS-922
Repository: mesos-git
Description
-------
This patch delegates the choice of executor to the containerizer by removing
executorInfo dependencies up until Containerizer::launch().
Containerizer::launch() now returns a future to the executor info that is being
run and the slave creates the corresponding executor structure when launch
completes.
This means message handling from the running executor to the slave in the
interim where the executor structure has not created, need to be enqueued until
executor is ready. So far, registerExecutor() and reregisterExecutor() has been
split into two continuations to deal with this issue.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp d9ae326
src/slave/containerizer/mesos_containerizer.hpp ee1fd30
src/slave/containerizer/mesos_containerizer.cpp c819c97
src/slave/http.cpp 594032d
src/slave/slave.hpp 01b80df
src/slave/slave.cpp d8d3e0f
src/tests/containerizer.hpp 5686398
src/tests/containerizer.cpp bfb9341
src/tests/gc_tests.cpp ac547cf
Diff: https://reviews.apache.org/r/18403/diff/
Testing
-------
make check
Thanks,
Niklas Nielsen
