----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19556/#review38349 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/19556/#comment70432> reads better as: if (!found) { return Error(...); } return None(); - Dominic Hamon On March 21, 2014, 4:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19556/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 4:41 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 8493155 > 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19556/diff/ > > > Testing > ------- > > make check on both OSX and Linux > > ALso, manually verified with the output from ifconfig/ip link show > > > Thanks, > > Jie Yu > >
