----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19556/#review38398 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/19556/#comment70525> kill new line. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/19556/#comment70530> Do you expect this to be used outside tests? 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/19556/#comment70526> Put each argument on its own line. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/19556/#comment70529> Kill the TODOO? - Vinod Kone On March 24, 2014, 10:16 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19556/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 8493155 > 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6 > 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19556/diff/ > > > Testing > ------- > > make check on both OSX and Linux > > ALso, manually verified with the output from ifconfig/ip link show > > > Thanks, > > Jie Yu > >
